From: Yang Z Zhang <yang.z.zhang@intel.com>
Date: Wed, 5 Jan 2011 23:37:32 +0000 (+0000)
Subject: libxl: fix free of uninitialised "disks" variable
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~10993
X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22Dat/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22Dat?a=commitdiff_plain;h=24a51dd87aba95edfac5030c49acaeaec4d872e2;p=xen.git

libxl: fix free of uninitialised "disks" variable

Reported-by: Wei Huang <wei.huang2@amd.com>
Reported-by: Christoph Egger <Christoph.Egger@amd.com>
Author: Yang Z Zhang <yang.z.zhang@intel.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 68889b9aa2..2c3fb0f72f 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -1402,8 +1402,8 @@ static char ** libxl_build_device_model_args_new(libxl__gc *gc,
             }
             libxl_device_disk_destroy(&disks[i]);
         }
+        free(disks);
     }
-    free(disks);
     flexarray_set(dm_args, num++, NULL);
     return (char **) flexarray_contents(dm_args);
 }